-
-
Couldn't load subscription status.
- Fork 10
feat: Airflow with Event-scheduling, Triggerer, Opa #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Lukas Krug <lukas.krug@stackable.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great demo! Worked fine for me.
Approving this already because my remarks are just nit picking.
Found one more nit:
The docs say in the last step that patches the Airflow cluster "To include this in the list of DAGs (without removing the existing ones) ...", but the patch actually removes the existing ones. Or maybe I misunderstand it.
So I'd either remove the part in brackets or add the other volume mounts to the patched Airflow resource.
Thanks! Have fixed that here: 7503715 |
Fixes #223
Requires stackabletech/docker-images#1313
N.B. to test before merging switch these links to local ones and call the demo with
-sand-dpointing to local files:e.g.
stackablectl demo install airflow-scheduled-job -s stacks/stacks-v2.yaml -d demos/demos-v2.yaml -n airflow-demoDemo tested on Kind using LoadBalancer provided by https://github.com/kubernetes-sigs/cloud-provider-kind.