Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Oct 21, 2025

Fixes #223
Requires stackabletech/docker-images#1313

N.B. to test before merging switch these links to local ones and call the demo with -s and -d pointing to local files:

e.g. stackablectl demo install airflow-scheduled-job -s stacks/stacks-v2.yaml -d demos/demos-v2.yaml -n airflow-demo

Demo tested on Kind using LoadBalancer provided by https://github.com/kubernetes-sigs/cloud-provider-kind.

@adwk67 adwk67 marked this pull request as ready for review October 23, 2025 09:35
@adwk67 adwk67 self-assigned this Oct 23, 2025
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Oct 23, 2025
@dervoeti dervoeti self-requested a review October 27, 2025 08:24
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 27, 2025
Co-authored-by: Lukas Krug <lukas.krug@stackable.tech>
dervoeti
dervoeti previously approved these changes Oct 27, 2025
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great demo! Worked fine for me.
Approving this already because my remarks are just nit picking.

Found one more nit:
The docs say in the last step that patches the Airflow cluster "To include this in the list of DAGs (without removing the existing ones) ...", but the patch actually removes the existing ones. Or maybe I misunderstand it.
So I'd either remove the part in brackets or add the other volume mounts to the patched Airflow resource.

@adwk67
Copy link
Member Author

adwk67 commented Oct 27, 2025

Great demo! Worked fine for me. Approving this already because my remarks are just nit picking.

Found one more nit: The docs say in the last step that patches the Airflow cluster "To include this in the list of DAGs (without removing the existing ones) ...", but the patch actually removes the existing ones. Or maybe I misunderstand it. So I'd either remove the part in brackets or add the other volume mounts to the patched Airflow resource.

Thanks! Have fixed that here: 7503715

@adwk67 adwk67 requested a review from dervoeti October 27, 2025 13:21
@adwk67 adwk67 merged commit 38a3146 into main Oct 28, 2025
2 checks passed
@adwk67 adwk67 deleted the feat/airflow-enhanced branch October 28, 2025 08:54
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

Airflow Demo: Extend to show 3.x new features

3 participants